Repository navigation
Conversation
GitHub blocks the merge until every commit has a verified signature, and external contributors often push unsigned commits. The guide tells them how to sign, how to sign pushed commits again, and to keep "Allow edits by maintainers" selected. The README links to it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the contribution guidance and README link updates.
No open issues 🎉
What changed in this PR
Adds contribution guidance for the Datadog Lambda Extension to help contributors meet verified-signature requirements and prepare pull requests.
Changes:
- Documents commit-signing setup and how to re-sign previously pushed commits.
- Explains pull request expectations and lists Rust check commands.
- Links the new guide from the README.
| File | Description |
|---|---|
| README.md | Links to repository-specific contribution requirements. |
| CONTRIBUTING.md | Adds signing instructions, pull request guidance, and check commands. |
Review effort: Balanced
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 3 Pipeline jobs failed
Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: 188b2fb | Docs | View more details | Give us feedback! |
Problem
GitHub blocks the merge of a pull request into
mainuntil every commit has a verified signature. An organization ruleset sets this requirement. External contributors often push unsigned commits, and the repository has no guide that tells them to sign. A maintainer then has to sign the commits again and push to the contributor's fork. This happened on #1431.This PR
CONTRIBUTING.mdwith three sections:The signing section follows the "Sign your commits" section in the
dd-trace-jscontributing guide. The check commands come from the Rust CI workflow,.github/workflows/rs_ci.yml.Testing
Steps
upstreamremote, made two unsigned commits on a branch.git rebase --exec 'git commit --amend --no-edit -n -S' $(git merge-base HEAD upstream/main).Result
git log %G?)N, no signatureG, good signatureNN, unchangedI did not run the three check commands for this PR, because it changes no code.
🤖 Generated with Claude Code