Repository navigation
chore(dev): patch-deps.sh to build against local dependency checkouts - #1478
duncanista wants to merge 10 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ab01123569
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
duncanista
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 229b80652b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…v-patch-deps/feature
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 08fcfb06bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…v-patch-deps/feature
… quoted paths and duplicate crates - Accept --force only with restore, so add and remove can not record an edited Cargo.lock as the new baseline. - Point an earlier add of the same checkout at the new path before resolving, so a moved checkout can be re-added. - Write checkout paths as escaped TOML strings. - Patch a crate in every source it comes from, not only the last one.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd76745918
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… its lock and name checks - add runs `cargo update` on a crate whose locked version differs from the local one (`--precise` for crates.io), so cargo selects the patch - the exit code comes from the resolved packages too, not only from the cargo warning that quiet mode hides - a deleted Cargo.lock counts as changed when a hash is recorded - status records the lock hash when the lock was unchanged before it ran - add refuses a second checkout with the same name while the first exists
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba019bb194
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…of a patched crate - status resolves with `cargo metadata --locked`. It never writes Cargo.lock or the recorded lock hash, and fails when the lock needs an update. - a crate is active only when no package of that name still comes from crates.io or git. The report lists each remote package with its version and source, and the command exits 3. - drop the stderr scan for unused patches and the conditional hash record in status, which the two rules above replace.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 842a081bc0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…ted patch tables in patch-deps
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 281cf50bfa
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…oves the last checkout
TL;DR: A script that points bottlecap at a local checkout of serverless-components or libdatadog, and restores
Cargo.tomlandCargo.lockafterwards.Why: Testing a dependency fix today means editing
Cargo.tomlby hand and remembering to undo it. This makes it one command, and it refuses to restore over edits it did not make.Overview
Jira: SVLS-9976
Stacked on #1477 (
jordan.gonzalez/dev-build-cache/feature).scripts/dev/patch-deps.shpoints bottlecap at local checkouts of serverless-components,libdatadog, saluki, dd-trace-rs or libddwaf-rust with
[patch]entries in a marked block,and removes them again.
add,remove,status,restore. The firstaddbacks upCargo.lockinbottlecap/.patch-deps/(ignored) with its sha256.statusshowsNOT USEDfor a patch that cargo does not use (version not semvercompatible with the lock); exit code 3.
restoreandremoverefuse to run (exit 4) when the lock changed after the backup, unless--force.Size: 249 core lines, 282 lines in total.
Testing
addthenrestoregives a byte-identicalCargo.tomlandCargo.lock.