Repository navigation
ci: informational benchmark workflow - #1475
Open
duncanista wants to merge 4 commits into
Open
duncanista wants to merge 4 commits into
duncanista wants to merge 4 commits into
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f82bb2637b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
🔗 Commit SHA: 321afd8 | Docs | View more details | Give us feedback! |
duncanista
changed the title
- Upload the exports with include-hidden-files, so the .bench-export directory reaches the artifact. - download-baseline: walk back through the last 10 green nightlies to the newest one that has a bench-baseline-main artifact. - bench-measure: on a labeled event, run only for the bench label, and give other label events their own concurrency group so they do not cancel a running measurement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: CI builds the benchmarks on PRs, and runs them on the
benchlabel and nightly on main.Why: It keeps the benchmarks compiling and gives a main baseline to compare a PR against. It is informational only and never blocks a merge.
Overview
Jira: SVLS-9977
Stacked on #1474 (
jordan.gonzalez/bench-suite/feature).Add
.github/workflows/bench.yml. No job blocks a PR.bench-build: every PR that touchesbottlecap/.cargo bench --no-run --lockedwith LTOoff. A failure gives a warning.
bench-measure: PRs with thebenchlabel, nightly onmain, and manual. Productionprofile, a fixed smoke list with
--quick(scripts/ci/bench-measure.sh). Nightly runs savethe baseline artifact
bench-baseline-main; a PR run compares with it (critcmp main pr -t 10) and writes the table to the step summary.The bench README now has a "CI" section with the wired part and the full plan.
Size: 245 core lines, 279 lines in total.
Testing