feat(governance): make analysis deterministic with ChangeContext (#79) - #167
Merged
ElliotSun merged 1 commit intoAug 14, 2026
Conversation
ElliotSun
force-pushed
the
79-make-governance-analysis-deterministic-through-explicit-changecontext
branch
from
August 13, 2026 23:29
e943951 to
3870be3
Compare
ElliotSun
marked this pull request as ready for review
August 14, 2026 02:27
ElliotSun
deleted the
79-make-governance-analysis-deterministic-through-explicit-changecontext
branch
August 14, 2026 02:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #79 by making governance-relevant date context explicit, reproducible, and owned at the application-service boundary.
Changes
ChangeContextcontaining only requiredeffective_datesemapact.services.GovernanceServiceas the application boundary that constructsChangeContextGovernanceDecisioneffective_datefor generated schema/propertydeprecationDatedeprecationDaterather than overwriting iteffective_datein deterministic decision identityContext ownership
effective_dateis the semantic date under which the contract change is evaluated. It is not an execution timestamp, PR timestamp, Git timestamp, or release timestamp.Lower layers consume the supplied
ChangeContext. They must not generate, default, overwrite, or re-resolve it from the wall clock.Until a persistent Draft/ChangeSet workflow owns and stores the effective date, current CLI governance operations accept an explicit
--effective-date YYYY-MM-DD. This is a request value, not CLI ownership ofChangeContext.Architectural boundary
ChangeContextis SemaPact runtime governance input, not an ODCS extension. This issue intentionally does not add actor, Git revision, DAB metadata, policy version, or release/version-authority fields.Release/version authority is tracked separately in #166.
Validation
Closes #79