Skip to content

Linting Fixes - #514

Open
eflumerf wants to merge 4 commits into
developfrom
eflumerf/Linting
Open

eflumerf wants to merge 4 commits into
developfrom
eflumerf/Linting

Conversation

@eflumerf

Copy link
Copy Markdown
Member

Description

This PR fixes issues identified by dbt-build --lint dfmodules.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

@eflumerf eflumerf self-assigned this Sep 29, 2026
@eflumerf eflumerf added the maintenance Addresses a user request or a change in another part of the system label Sep 29, 2026
@eflumerf
eflumerf marked this pull request as ready for review September 29, 2026 18:50
@eflumerf

Copy link
Copy Markdown
Member Author

Note that dfmodules has experienced "develop drift" with respect to the v5.7.0 branches, so there may have to be some complicated merges to make all of the formatting changes happy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Addresses a user request or a change in another part of the system

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants