Skip to content

Johnfreeman/dotgithub issue27 nomerge - #356

Closed
jcfreeman2 wants to merge 1223 commits into
johnfreeman/documentation_orgfrom
johnfreeman/dotgithub_issue27_nomerge
Closed

jcfreeman2 wants to merge 1223 commits into
johnfreeman/documentation_orgfrom
johnfreeman/dotgithub_issue27_nomerge

Conversation

@jcfreeman2

Copy link
Copy Markdown
Collaborator

Do Not Merge; PR is used to test a workflow

If full description and testing details are included on a parent issue, please link to that here.
See issue # for details

Otherwise, please include a summary of the change and which issue is fixed (if any).
Include relevant motivation and context, including a target environment and dunedaq version if known.
Also list any dependencies that are required for this change.

Addresses issue #

Please also include instructions for how a reviewer can test your changes.

Type of change

  • Documentation (non-breaking change that adds or improves the documentation)
  • New feature or enhancement (non-breaking change which adds functionality)
  • Optimization (non-breaking change that improves code/performance)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (whatever its nature)

Testing checklist

  • Unit tests pass (e.g. dbt-build --unittest)
  • Minimal system quicktest passes (pytest -s minimal_system_quick_test.py)
  • Full set of integration tests pass (dunedaq_integtest_bundle.sh)
  • Python tests pass if applicable (e.g. python -m pytest)
  • Pre-commit hooks run successfully if applicable (e.g. pre-commit run --all-files)

Comments here on the testing

Further checks

  • Code is commented where needed, particularly in hard-to-understand areas
  • Code style is correct (dbt-build --lint, and/or see https://dune-daq-sw.readthedocs.io/en/latest/packages/styleguide/)
  • If applicable, new tests have been added or an issue has been opened to tackle that in the future.
    (Indicate issue here: # (issue))

eflumerf and others added 30 commits February 17, 2026 10:56
Removed unneeded capsys argument to integtest function calls; added --pytest-options argument to the bundle script
Add support for skipping system resource checks
…_in_integtests

Added checking of computer resources in integtests
Properly set TC readout window sizes for daqsystemtest after updates in config
…_scan_test.py to correctly take into account the time span of TDEEth frames compared to the size of the readout window in this test.
Modified the expected size range for TDEEth fragments in readout_type_scan_test.py…
Configuration objects for DataMoveCallbackRegistry
…_script

Updated the bundle script summary to show a red X icon for tests with errors…
Added an ignored logfile warning about absl log messages to the example_system_test
…ig_session_name and renamed drunc_config session_name as daq_session_name to help make their meaning more clear. Also removed obsolete references to data_rate_slowdown_factor.
…test

Adds integration test coverage for DAPHNEEth and DAPHNEEthStream frame
types in readout_type_scan_test.py, including fragment parameter
definitions, test configurations, and dispatch logic in test_data_files().

Both DAPHNEEth and DAPHNEEthStream configs use use_fakedataprod=True
rather than asset file URIs, as no registered asset files currently exist
for these frame types. The asset:// URI lines are preserved as comments
with TODO markers so they can be restored once appropriate sample data
files are available.

The DAPHNEEth_TPG_System test is disabled (commented out in
confgen_arguments) because TPG validation requires realistic frame data
to produce meaningful trigger primitives; fake data is insufficient for
that test.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
andrewmogan and others added 29 commits September 3, 2026 14:02
Candidate version for fddaq-v5.7.0
Changes made in response to testing with the k8s process manager
…yellow circle in front of warning messages.
…intout

bundle script changes to improve handling of spaces in -r/-k/-R/-x options
@jcfreeman2 jcfreeman2 closed this Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.