You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Added more information to the comments at the top of the sample_ehn1_… - #355
Hi @bieryAtFnal, thanks for the improvements.
I think the changes to the documentation are good and should stay.
My problem / surprise is this (and it can fully be wrong assumptions on my side):
By default I run dunedaq_integtest_bundle.sh (without any other flags) to test sw (be it RCs, releases, nightlies). They are generally all expected to run (and pass), with the only caveat that some may be skipped because the machine they are being run on does not have enough resources (ie somethine that is inherent to the machine, not a setup/config of the test).
This seems to be the first test that requires additional setup to run/start successfuly that is not dependent on the resources but, in this case, instead on providing a path. So my quesion is:
is this how we want it to work? ie skipped by default (with the error message shared on slack). If that is the case, does it make sense to be included in the default bundle if we just assume it will be skipped?
would we like it to be run by default? In that case, are there things we could do to make it run by default without additional manual setup? Perhaps trying to set the path to say $HOME/tmp-dir-hash and then delete that after? Or something more elegant?
Otherwise, I can also just add an export for PYTEST_DEBUG_TEMPROOT to one of the ehn1 scripts. This would work for ehn1 only ofc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…multihost_test.py.
Description
The goal is to make the special conditions under which the test can run fully more clear.