Repository navigation
Updates to the way that the bundle script (and friends) find integtests - #352
bieryAtFnal wants to merge 15 commits into
Conversation
…a simpler model for finding integtests, and to better handle python packages that were installed with the '-e' option.
…integtest_bundle.sh script
|
Here is a newer version of the slides. The main change is that I fixed some typos in the suggested software-area-setup commands on Slide 8. |
|
Following the slides, I ran the following tests. The intended behaviour was achieved - when a python-only repository was installed with I chose to run only tests with local 1 - test with a candidate release. 2 - test with a nightly |
… summary when verbosity level is 6; reversed the order of the last two places where we look for Python-package integtests.
There was a problem hiding this comment.
Approved. Rather than repeat what Pawel did, I instead took advantage of the root access available in ghcr.io/dune-daq/nightly-release-alma9:development_v5. I copied over the three files in daqsystemtest which differ on this feature branch relative to develop into /cvmfs (thus creating a de-facto Spack installation of daqsystemtest on this feature branch). Then I created an internal tester account which I logged into and rather than creating a local work area, I just did dbt-setup-release for the nightly in the container, and confirmed a few things:
- That
list_repos_with_integtests.shandlist_available_integtests.shworked - That
dunedaq_integtest_bundle.sh -r all -k 'min|basic|no_dup' --verb 2worked (in the sense of, attempted to run the tests - they failed b/c they won't work out of the box in the container)
…and getting repo types.
…ow up in the bundle script summary
Description
Sometime in the medium past, Pawel noticed that the script that we use to run integtests (the "bundle" script) wasn't handling the case in which a Python package had been installed with
pip install -e. The "-e" qualifier confuses things because the Python package does not appear underneath the virtual environment directory (.venv) in the same way as when we use thepip installcommand without the "-e" qualifier.As part of fixing that, I looked into ways to more cleanly locate integtests, and I made some changes to the bundle script itself, and its two helper scripts,
list_repos_with_integtests.shandlist_available_integtests.sh.I'll attach some slides to this PR with additional information.
There are lots of ways to set up a DUNE-DAQ software environment, so testing these change fully could become time consuming. I will post sample instructions here, and there are testing suggestions in the attached slides. The general pattern for the testing is to set up different types of software environments and confirm that the expected set of integtests is found in each of them.
Type of change
Testing checklist
dunedaq_integtest_bundle.sh)Further checks