Skip to content

fix(admin): link the Quote PDF designer from the sidebar again - #852

Merged
evilguy4000 merged 1 commit into
DRYTRIX:developfrom
jayhemnani9910:fix/quote-pdf-template-link
Nov 7, 2026
Merged

evilguy4000 merged 1 commit into
DRYTRIX:developfrom
jayhemnani9910:fix/quote-pdf-template-link

Conversation

@jayhemnani9910

Copy link
Copy Markdown
Contributor

Description

Since 5.19.0 the admin sidebar has one "PDF Templates" link, to the invoice designer. The old submenu had "Invoice PDF" and "Quote PDF"; the app shell rework (584bafa) dropped the quote entry, so /admin/quote-pdf-layout can only be reached by typing the URL.

The sidebar now has the two links again, with the labels and icons the submenu used. Each is highlighted on its own page.

"Invoice PDF" and "Quote PDF" are marked obsolete (#~) in the .po files since the rework, so other languages show them in English until the catalogs are extracted again.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Checklist

  • My code follows the project's style guidelines (Black, flake8).
  • I have added/updated tests for my changes.
  • All tests pass locally (e.g. pytest).
  • I have updated the documentation if needed.
  • For user-facing changes, I have added an entry to the Unreleased section of CHANGELOG.md.

Test: test_quote_pdf_layout_navigation_link_exists renders /admin/settings as an admin and looks for the quote designer URL. It fails on develop and passes with the change. Related suites pass: test_pdf_layout, test_keyboard_shortcuts, test_routes.py, tests/test_routes/, the admin, UI and template tests (test_analytics.py::test_login_analytics fails on develop too, unrelated).

Related issues

Fixes #850

…IX#850)

The 5.19.0 sidebar rework turned the PDF Templates submenu into a single
link to the invoice designer, so the quote designer could only be
reached by typing its URL. Show the Invoice PDF and Quote PDF links
again, each highlighted on its own page.
@evilguy4000
evilguy4000 merged commit d7551ab into DRYTRIX:develop Nov 7, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New release (5.19.0) hides quote PDF template

2 participants