Repository navigation
Comparer.merge keeps time steps where only an auxiliary value is missing - #738
Open
ecomodeller wants to merge 1 commit into
Open
ecomodeller wants to merge 1 commit into
ecomodeller wants to merge 1 commit into
Conversation
Closes #726 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #726.
merge()dropped every time step with a NaN in any variable, auxiliary ones included. It now drops only where the observation or a model is missing, asmatch()does. The docstring states that merging restricts all models to the time steps they share.🤖 Generated with Claude Code