Repository navigation
Circular metrics for directional quantities everywhere; raise on linear ones - #737
Open
ecomodeller wants to merge 1 commit into
Open
ecomodeller wants to merge 1 commit into
ecomodeller wants to merge 1 commit into
Conversation
…linear ones cc.skill(), mean_skill(), score() and gridded_skill() ignored is_directional and used linear metrics by default. Asking for a built-in linear metric on a directional quantity now raises, naming the circular one. A collection that mixes directional and scalar quantities raises until one is selected. Closes #725 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #725.
Only
Comparer.skill()used circular metrics by default.cc.skill(),mean_skill(),score()(both) andgridded_skill()computed linear bias/rmse on angles: 1° vs 359° scored 358°.Behaviour changes:
score()defaults toc_rmsethere (itsmetricdefault is nowNone).bias,rmse,cc, …) on a directional quantity raises and names the circular one. Custom metrics are passed through.skill/score/mean_skill/gridded_skilluntil one quantity is selected withsel(quantity=...). Before, the direction rows were silently linear.plot.taylor()raises for directional data, since it is built on linear std and correlation.🤖 Generated with Claude Code