Repository navigation
Fix issue with IM datasets when multiple maps on the same page - #485
Open
davidjamesstone wants to merge 4 commits into
Open
davidjamesstone wants to merge 4 commits into
davidjamesstone wants to merge 4 commits into
Conversation
…e dataset plugin initialization
- Updated @defra/interactive-map from 0.0.33-alpha to ^0.0.56-alpha in package.json. - Changed import for createDrawPlugin from draw-ml to draw in geospatial-map.js and map.test.js. - Added workerPath configuration for maplibre-gl worker in map.js. - Updated map creation logic to include workerPath in createMap function. - Added ignoreWarnings for maplibre-gl in webpack.config.js to suppress critical dependency warnings.
|
davidjamesstone
changed the title
davidjamesstone
marked this pull request as ready for review
October 23, 2026 16:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
When multiple maps are on the same page and datasets are configured (SSSI or country boundary) then the latter maps also get initialised with the same datasets as those above it when they shouldn't be.
This PR currently contains half the fix but we need to wait for an update to IM to make datasets not work globally (which Dan L is aware of and fixing)
Jira ticket: https://eaflood.atlassian.net/browse/DF-1571
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).