Repository navigation
docs: dependency bump and fix failing pipeline - #484
Merged
Merged
Conversation
forms-model 4 exports the output condition as an enum that holds a Joi reference object. jsonschema2md cannot render an object enum value, so schema doc generation crashed and the docs deploy failed. The enum is removed because its allowed values come from the form's conditions rather than a fixed list.
v1.0.0 adds react-router-dom ^5.3.4 as a peer dependency, so it is now declared as a direct dev dependency next to react and react-dom.
The parameter type and runtime guard now narrow the value, so the cast inside the function is no longer needed.
alexluckett
marked this pull request as ready for review
October 22, 2026 22:43
The schema docs script is over the 500-line limit that SonarCloud sets for one file. The enum cleanup is a self-contained schema transform, so it now has its own module.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
Bump defra-theme-govuk and fix the failing pipeline.
Jira ticket:
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).