Repository navigation
Conversation
nayij
marked this pull request as draft
October 21, 2026 14:08
nayij
marked this pull request as ready for review
October 21, 2026 14:45
|
Scullyon
approved these changes
Oct 23, 2026
Scullyon
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Might be worthwhile adding in an explicit test for escapeMarkdown that's in the file src/server/plugins/engine/components/helpers/index.ts
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Proposed change
A multiline answer with lines starting with
>(e.g.> first/>/> second) caused a 500 on Check your answers.escapeMarkdowndidn't escape>, so the answer was read as a quote, andmarkedthrew on the blank line inside it (Token with "space" type was not found). This escapes>so the answer shows as typed, on the summary page and in GOV.UK Notify emails.Jira ticket: DF-1535
Type of change
Checklist
README.mdanddocs/*(where appropriate, e.g. new features).npm run test).npm run lint).npm run format).