Skip to content

CellStructureMech and TaxonMech are the same colour on the light theme #78

Description

@realmarcin

Found reviewing #77, in code that PR does not touch.

CellStructureMech and TaxonMech are painted the same colour on the light theme, and all but the same colour on the dark one.

theme CellStructureMech TaxonMech
light #5257C9 #5257C9
dark #8a8ef5 #8b8fe8

On light they are byte-identical, so the two ring nodes, the two card spines and the two dots in the heatmap row headers carry no distinction at all. On dark the pair is the closest in the palette by a wide margin.

The colours are each Mech's identity across the page, so this is not only a chart-legend problem: a reader who has learned that periwinkle means cell structures now sees the same periwinkle for taxa.

NaturalProductMech also moved into the blue family in the same change, #0b5fa5 on light and #79b8f3 on dark, which puts three of the ten in blue alongside CommunityMech.

The comment above the tokens says the original eight already filled the hue circle at that lightness, and that NaturalProductMech had to separate by depth instead. A ninth and tenth member need the same treatment, checked against all the others in both themes and for colour-vision deficiency, rather than a value copied from a neighbour.

Not fixed in #77: choosing two brand colours that clear the separation floor against eight others in two themes is palette work, and #77 has no business picking them.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions