Skip to content

The citation-prefix list is duplicated across two pipeline scripts #61

Description

@realmarcin

Found reviewing #60.

Which prefixes count as citations rather than vocabularies is now written down in two places that cannot see each other:

  • scripts/fleet/build_subsets.py:172 skips them with a literal if p in ("DOI","PMID"): continue, which is why they have no record counts.
  • scripts/fleet/build_data.py declares CITATION=["PMID","DOI"] to pin them to the right of the heatmap.

Add a third citation prefix to one and the other keeps treating it as a vocabulary. In the heatmap that shows up as a column that sorts to the far left on Mech count with a record total of zero, which is exactly the failure the pin exists to prevent.

There is a related split in the same area. PREF in build_subsets.py lists DOI but not PMID, while VOC in build_data.py lists both, so PMID occurrences reach the heatmap only through prefix_census.py. Two scripts disagree about whether PMID is a prefix they handle.

Fix would be a single declaration the later scripts import, most naturally in build_subsets.py since it owns the skip.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions