Skip to content

Heatmap outlines are inconsistent: hover and focus draw inset, column highlight draws outward #57

Description

@realmarcin

Found reviewing #49.

Four rules now outline a heatmap cell and they do not agree on where the ring sits.

  • td button:hover gained outline-offset: -2px, so hover draws inside the cell.
  • td button:focus-visible draws two inset bands.
  • td.hi draws a 2px outline with no offset, so it sits outside the cell.
  • td.sel does the same.

With border-spacing cut from 3px to 2px, the outward outlines of two adjacent highlighted cells each claim the full 2px gap between them, so the column highlight reads as one continuous band instead of nine rings. For a whole-column highlight that may be the better look, which is why this is filed rather than fixed. Worth a decision either way, so the four rules stop disagreeing by accident.

Separately, td.sel is dead. The class is declared in the stylesheet and never applied: state.sel in the graph code is unrelated and no code path adds sel to a heatmap cell. Searched the fragment source and the generated page.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BXHrBTSU8fU4Zg7HfaMKs9

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions