Skip to content

The heatmap cell focus ring disappears on mid-shade cells #54

Description

@realmarcin

From the adversarial review of #49. The focus and hover outline on a heatmap cell button is a fixed var(--neon), but the cell background is a color-mix that sweeps the full range from card to accent-2 as the value grows. The ring's luminance sits inside that range in both themes, so contrast passes through 1:1: in the light theme cells around data-l 60 to 75 put the ring under about 1.3:1, and at data-l 100 it is 1.86:1, below the 3:1 WCAG 1.4.11 asks of a focus indicator; in dark the crossing lands around data-l 65 to 85. Those bands are populated. A two-tone ring would fix it, for instance an outer outline in var(--ink) with an inner one in var(--neon), so one of the two always contrasts with whatever shade the cell is.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions