Skip to content

Make new embedding modules pass the declared mypy gate #910

Description

@realmarcin

After the canonical runtime/helper formatting fixes arrived through governed sync, CommunityMech's declared just lint progressed past Black and Ruff and exposed four new mypy errors in src/communitymech/text_map_inputs.py:

  • line 102: the identity tuple can return Any | None where str is required;
  • line 113: lines needs a collection annotation;
  • line 143: paths needs a collection annotation;
  • line 220: an optional destination is passed to Path.replace without narrowing.

The completed same gate also reports embedding/dimensionality.py:71: the new PaCMAP import crosses an untyped library boundary without an explicit annotation. This fifth failure was captured when the full mypy invocation finished.

These errors occur in an unchanged frozen dependency environment using the repository's normal mypy configuration. They are part of the new common-map integration, not baseline data failures. The current source and publication fixture fixes have already passed their focused checks; the full suite had 3,235 other tests passing.

Acceptance: explicitly narrow the identifier and destination, annotate the new collections, and handle the untyped PaCMAP import boundary; preserve all 372 full exported JSONL records byte-for-byte; rerun just lint and focused adapter/graph tests. Keep the repository's typing configuration and dependency lock unchanged.

Evidence: remediation workspace required-validation/communitymech/governed-final-lint.log. Existing open common-map issues were checked; #907 covers shell arguments and #909 covers renderer fixture corpus roots, so this gate defect is separate. Coordinates with CultureBotAI/culturebotai-claw#426.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions