Independent review finding for the proposed semantic-map adapter/site integration under CultureBotAI/culturebotai-claw#426. This concerns the currently unpushed review commit 6325fe9078ea52528050a534f8ad6b50fca617e4, not a claim that the new recipe already exists on main.
The new justfile:804 recipe interpolates {{args}}. Running:
just text-map-inputs --output "/tmp/map review/inputs.jsonl"
passes two path arguments (/tmp/map and review/inputs.jsonl) to the Python CLI instead of the one quoted path. The same problem affects --root and --record values containing spaces. The real adapter therefore rejects a supported invocation before producing the requested export.
This was reproduced with the actual just executable and a harmless uv argument-capture stub, without running models or changing reviewed source. Captured arguments after --output were split. The repository already enables set positional-arguments := true, and its existing safe recipes forward "$@".
Acceptance:
- Forward the new recipe's arguments without shell re-splitting, using the existing positional-argument convention.
- Exercise the actual recipe boundary with a path containing spaces; assert one exact argument reaches the CLI (a harmless executable stub is sufficient).
- Keep full/subset CLI behavior and all adapter/site checks passing.
Local review evidence: workspace/embedding-remediation-20260915/graph-text-recipe-review.json in the CLAW task workspace. The frozen source was left unchanged during review.
Independent review finding for the proposed semantic-map adapter/site integration under CultureBotAI/culturebotai-claw#426. This concerns the currently unpushed review commit
6325fe9078ea52528050a534f8ad6b50fca617e4, not a claim that the new recipe already exists on main.The new
justfile:804recipe interpolates{{args}}. Running:just text-map-inputs --output "/tmp/map review/inputs.jsonl"passes two path arguments (
/tmp/mapandreview/inputs.jsonl) to the Python CLI instead of the one quoted path. The same problem affects--rootand--recordvalues containing spaces. The real adapter therefore rejects a supported invocation before producing the requested export.This was reproduced with the actual
justexecutable and a harmlessuvargument-capture stub, without running models or changing reviewed source. Captured arguments after--outputwere split. The repository already enablesset positional-arguments := true, and its existing safe recipes forward"$@".Acceptance:
Local review evidence:
workspace/embedding-remediation-20260915/graph-text-recipe-review.jsonin the CLAW task workspace. The frozen source was left unchanged during review.