rails-vue: ship ui/public/tokens.css and ui.css - #20
Closed
ahmad-ajmal wants to merge 1 commit into
Closed
ahmad-ajmal wants to merge 1 commit into
ahmad-ajmal wants to merge 1 commit into
Conversation
The template's `.gitignore` meant to ignore the Rails-served build output at its root, but the unanchored `public/` also matched `ui/public/`, so the kit token sheet and the component styles the View links (/tokens.css, /ui.css) were never committed. A scaffolded rails-vue app shipped unstyled. Anchor the rule to the template root and add both sheets, vendored in lockstep with the React blueprints (the Vue View uses the same classes). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gitignoremeant to ignore the Rails-served build output at its root. Its unanchoredpublic/also matchedui/public/, so the token sheet and component styles the View links (/tokens.css,/ui.css) were never committed. Every scaffolded rails-vue app shipped unstyled./public/), and both sheets are added, vendored in lockstep with the React blueprints. The Vue View uses the same class names.git check-ignoreconfirmsui/public/is tracked while the rootpublic/build output stays ignored. A freshscaffold --blueprint blueprint-rails-vuecontains both files, andvite buildcopies them into the servedpublic/.Found while working on #18.
🤖 Generated with Claude Code