fix(collaboration): validate local user fields - #407
Draft
seonghobae wants to merge 2 commits into
Draft
Conversation
Signed-off-by: Seongho Bae <me@seonghobae.me> Commit-Message-Assisted-by: Claude (via Claude Code)
Signed-off-by: Seongho Bae <me@seonghobae.me> Commit-Message-Assisted-by: Claude (via Claude Code)
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #297
Scope
userId,displayName, andcursorColorruntime types before normalizationDependency boundary
This Draft is stacked on #406 / exact base
02f55466c0111bb53c6886f5d4a95de2068e944a. The #297 delta changes onlysrc/collaboration/awareness.tsand its existing unit test.Exact-head local evidence
For exact head
7a7093b92616296be6b4c3c7ce990880d12f8271:e37b10e: 10 failed / 30 passedpnpm test: 160 files / 901 tests passedpnpm run coverage: 100% statements, branches, functions, and linespnpm run typecheck: passedpnpm run build: passedpnpm run verify:package: passedLocal and predecessor evidence does not transfer approval or protected-main authority. Keep Draft until #406/#403/#405 integrate or the dependency chain is otherwise resolved, and while #118 owns the protected release boundary.