Skip to content

fix(collaboration): validate public contrast colors - #404

Draft
seonghobae wants to merge 2 commits into
mainfrom
codex/contrast-color-validation-305
Draft

fix(collaboration): validate public contrast colors#404
seonghobae wants to merge 2 commits into
mainfrom
codex/contrast-color-validation-305

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Closes #305

Scope

  • reject non-string and malformed public contrast-color inputs before channel parsing
  • preserve the existing six-digit hexadecimal grammar and WCAG relative-luminance result for valid values
  • reuse the isolated RED/GREEN lineage from closed Draft fix(collaboration): harden awareness runtime contracts #167 on current protected main

Exact-head local evidence

  • RED on test-only 28b18ede6008da34a6c671f3b740407b3bdfce31: 5 failed / 1 passed
  • focused GREEN: 6 / 6 tests passed
  • pnpm test: 157 files / 887 tests passed
  • pnpm run coverage: 100% statements, branches, functions, and lines
  • pnpm run typecheck: passed
  • pnpm run build: passed
  • pnpm run verify:package: passed

The existing collaboration documentation already states the six-digit color grammar and relative-luminance behavior, so this issue-specific repair does not change public authority or host/provider ownership. Keep Draft while #118 owns the protected release boundary; no predecessor checks or approvals transfer.

Signed-off-by: Seongho Bae <me@seonghobae.me>

Commit-Message-Assisted-by: Claude (via Claude Code)
Signed-off-by: Seongho Bae <me@seonghobae.me>

Commit-Message-Assisted-by: Claude (via Claude Code)
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(data-integrity): fail closed on invalid public contrast colors

1 participant