Skip to content

feat(diagnostics): add collaborative writing-guidance parity - #281

Draft
seonghobae wants to merge 35 commits into
feat/writing-diagnostics-editor-actionsfrom
feat/writing-diagnostics-collaboration
Draft

feat(diagnostics): add collaborative writing-guidance parity#281
seonghobae wants to merge 35 commits into
feat/writing-diagnostics-editor-actionsfrom
feat/writing-diagnostics-collaboration

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Stack authority

This Draft is the existing collaborative writing-diagnostics parity lane stacked on current #280 feat/writing-diagnostics-editor-actions@d8749ec18578b256d36b8dc52ba0eb5bbe1b5a29. Current exact head is feat/writing-diagnostics-collaboration@14a01a8c95b4dcdc14bbcb04c4c5ed0476a857ba. Protected shipped truth remains main@3b38ead2d00f44eb578d0689087b9293b3dabe1e; release issue #118 continues to freeze v0.6.0 publication.

The parent-only Semgrep-classification repair in src/components/CwlEditor.writingDiagnosticApply.test.tsx was synchronized non-destructively into this existing branch. Fresh comparison resolves merge base exactly to current #280 and reports this branch ahead 32 / behind 0; this lane's effective child delta remains its seven collaboration/workflow paths. Earlier synchronization SHAs and their evidence are predecessor lineage only.

Included behavior

This lane provides collaborative parity for already-verified host diagnostics: host-supplied props, accessible guidance panel and imperative Focus / Apply / Ignore / Dismiss / Explain methods; exact strong-revision verification before local Apply; plain-text replacement through an ordinary collaborative ProseMirror/Yjs transaction; immediate stale-all invalidation for local or remote changes; two-client convergence and collaborative undo/redo; no fabricated remote action events; read-only Apply prevention; stable editor identity/latest callback ownership; race rejection when remote updates arrive during verification or pending Apply digest; awareness privacy; and host ownership of supplied Y.Doc lifecycle.

Inkspan performs no semantic inference and calls no LLM/model provider/network reviewer/database/persistence service. Diagnostic identifiers, titles, explanations, replacements, revisions, provenance and authored text are not written into awareness state.

Exact-current-head evidence

At the latest pre-write refetch:

  • PR is open, Draft; current exact head is 14a01a8c95b4dcdc14bbcb04c4c5ed0476a857ba;
  • live predecessor feat(diagnostics): integrate revision-safe actions into CwlEditor #280 is exactly d8749ec18578b256d36b8dc52ba0eb5bbe1b5a29 and is the merge base;
  • PR-triggered workflow lookup for this exact head returns no current generation, so exact-head workflow evidence is absent/non-passing; predecessor/push/status evidence cannot substitute;
  • formal submitted reviews: 0;
  • unresolved inline review threads: 0;
  • qualifying independent approval: 0.

Waiting for the existing stacked-PR CI owner path (#298/#299) blocks only this evidence lane. #282 owns the framework-independent package subpath.

Integration boundary

Keep Draft behind #280. Before any lifecycle transition independently refetch current parent/head ancestry, live governance, all applicable exact-head workflows, formal reviews and threads, then respect #118's protected release boundary. Pending/queued/skipped/cancelled/absent/neutral/failed/stale/predecessor/status-only/model-only evidence is non-passing. Do not self-approve, force-push, destructively rebase, transfer predecessor evidence, weaken gates, create a tag/release, claim host semantic/model authority, or add transport/persistence/credential/model authority.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…actions' into feat/writing-diagnostics-collaboration

Signed-off-by: Seongho Bae <me@seonghobae.me>
@seonghobae

Copy link
Copy Markdown
Contributor Author

#281 was restacked onto the current #280 head b415d36.

Exact head: 37203e6

Verification on that tree:

  • focused collaborative diagnostics tests: 4 files, 9 tests passed
  • full Vitest coverage: 186 files, 1048 tests passed
  • statements, branches, functions, and lines: 100%
  • effective PR delta remains the intended seven files
  • hosted head/base OIDs and file list re-fetched after push; mergeable is MERGEABLE

Checks are queued before runner assignment.

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

…actions' into feat/writing-diagnostics-collaboration
…actions' into feat/writing-diagnostics-collaboration
@seonghobae seonghobae added the enhancement New feature or request label Sep 7, 2026 — with ChatGPT Codex Connector
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority: medium Normal-priority or P2 work status: draft Draft pull request type: feature New or expanded product capability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant