test(react): contain native reset updates inside act - #153
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Seongho Bae <me@seonghobae.me>
Signed-off-by: Seongho Bae <me@seonghobae.me>
|
Restacked the unchanged test-only React reset boundary onto protected |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Remove the duplicated Python support contract changes from this form-reset branch. PR #405 remains the single writer while this branch keeps its collaborative reset warning fix. Signed-off-by: Seongho Bae <seonghobae@users.noreply.github.com> Commit-Message-Assisted-by: Claude (via Claude Code)
Signed-off-by: Seongho Bae <me@seonghobae.me>
Canonical editor-owner restack and current proof — 2026-09-06Candidate The former body contained obsolete head/base, workflow and release-generation snapshots. It now describes the durable test scope and canonical stack; none of those predecessor receipts is transferred to this candidate. Fresh final-head verification:
Keep Draft and integrate the source owner first. These bounded-worker local results do not establish default/hosted-load reliability, installed-tarball browser identity, physical-device/OS-IME acceptance, a performance target, current central review, independent approval, protected merge or release. No gate, timeout, principal or allowed authority was weakened, and no valid predecessor delta was dropped. |
CodeQL dispatch admission, not a source finding — 2026-09-06Current PR head is Consumer run 34019468660, The actual central results are now terminal:
This is the same bounded scheduler-identity rejection observed in #402's The older event also supplied base |
Purpose and causal boundary
Keep native-form reset test updates inside React's asynchronous test boundary. This lane carries the narrowly scoped repair originally prompted by a hosted collaborative reset diagnostic in #149: both dispatching the native reset event and settling its existing queued task belong inside async
act().The complete net delta is
src/components/editorFormSerialization.test.tsx. The helper still returns whether the cancelable native reset was allowed, and existing cases still cover canceled resets, external form association, synchronous form values and host-authorized collaborative reset handling. It does not change editor/runtime behavior, public APIs, collaboration authority, dependencies, workflows, release metadata or security policy.Canonical owner stack
This Draft test-only lane is stacked on #201 (
fix/atomic-controlled-sync-200), which inherits the #176 and #402 prerequisites. Integration uses ordinary merge history and preserves this lane's unique helper repair. #201 remains the standalone editor source owner; this PR does not duplicate or replace its controlled-input, composition, teardown or policy implementation.Protected
mainremains shipped implementation authority. Dependency proposals and locally verified candidates are not protected or released behavior. Do not carry the former body's stale head, protected-main SHA, workflow IDs or mergeability claims forward as current evidence; dated verification belongs in exact-head comments.Verification and integration discipline
Before any lifecycle transition, refetch the exact candidate and live parent/protected base, ancestry, active writers, changed paths, formal reviews/threads, applicable repository and central checks, and live protection/rulesets. Preserve the full test denominator and failure logs, and distinguish constrained local worker settings from hosted/default execution. Local unit, browser and package success does not establish a protected merge, publication, central review or independent approval.
Keep Draft and integrate the parent first. Missing, queued, skipped-required, failed, stale, predecessor, status-only, wrong-checkout or model-only evidence remains non-passing. Release issue #118 remains the stable-release operational-acceptance boundary; this test-only repair does not authorize a tag or publication. Do not self-approve, bypass or weaken gates, force-push, destructively rebase, create a competing writer or discard any valid predecessor delta.