feat(network): subscribe to committed navigation events - #262
feat(network): subscribe to committed navigation events#262seonghobae wants to merge 25 commits into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Fresh parent-first repair evidence: this PR is no longer clean against its actual live parent. PR #261's branch is now I reconstructed the unique six-file subscription delta non-destructively on the current parent as Draft #277, exact head Do not close this PR yet. #277 must first obtain exact-head repository-native coverage/contracts and applicable governance evidence, then unique-delta equivalence can be rechecked. Only after that is this PR safely superseded and #263 eligible for parent-first reconstruction/restack. |
Partial implementation of #28, stacked directly on live PR #261 branch
feat/webdriver-bidi-navigation-origin-bindingexact headda84955d74ff12b158a8cb2e75eadf218c787f46.Buyer-visible boundary
A conforming WebDriver BiDi local end must explicitly subscribe before relying on
browsingContext.navigationCommitted. This Draft owns the complete narrow subscription exchange for exactly that event and one already-registered OriginWeave browsing context:session.subscribecommand serialization only forbrowsingContext.navigationCommitted;session.SubscribeResult.subscriptionidentifier under a 4096-byte local retention bound;The boundary does not expose arbitrary event names, global/user-context subscription authority, generic JSON/method dispatch, raw browser authority, or any inference that successful subscription authorizes navigation, destination, origin, action, policy, secret use, or proves that an event has fired.
Primary specification checked against the WebDriver BiDi Editor's Draft:
session.SubscribeParameterspermits event/context scoping andsession.SubscribeResultcontains one opaque textsubscriptionidentifier.Test-first lineage
Exact test-only head
9ab369c4dc406aef19dcecacc50304224c060242introduced the realistic loopback TCP → RFC 6455 opening exchange → maskedsession.subscribeframe → local-end success response → message assembly → exact correlation regression before production support existed.The implementation subsequently added the typed command/response boundary and repaired repository-contract and exact-production-coverage findings on this same canonical branch. Later ancestor convergence moved the live base and contributor head; no parent/predecessor checks, reviews, or coverage are transferred to the current exact state.
Fresh exact-head evidence
Current contributor head:
9df2fc23abf42133beaebab4f5466fbdc942d336.Current live base: PR #261 exact
da84955d74ff12b158a8cb2e75eadf218c787f46.Fresh ancestry has that exact base as the merge base, with this branch ahead by its twenty-five subscription commits and not behind. GitHub reports this PR open, Draft, and mergeable.
Exact native CI run
33440991551completed success on this unchanged current head:99648880437: exact checkout, repository contracts, canonical formatting, workspace check, full tests, strict Clippy, and rustdoc success;99648880775: exact owned-production function/line/region/branch measurement, diagnostics upload, and exact enforcement success.Fresh formal reviews and inline review threads are empty. Those absences are not represented as approval or passing review evidence. Central workflow results not returned for this exact stacked head remain absent evidence; live governance issue #215 owns the effective central-gate verification.
Remaining stack boundary
Keep Draft while #261 and its ancestors remain Draft. Event admission and later subscription teardown remain independently reviewable lifecycle work and are owned by the existing descendant stack; this PR itself does not infer active event authority merely from command/receipt success.
Protected-main
AGENTS.mdand live GitHub governance remain authoritative. The active organization ruleset requires one independent approving review, stale-review dismissal after pushes, resolved review threads, and the listed central workflows. This scheduled branch does not merge, self-approve, use admin bypass, force-push, destructively rebase, alter workflows/rulesets/secrets, weaken checks, tag, release, or publish.