Skip to content

fix(actions): verify coalescer cancellation completion - #1887

Merged
seonghobae merged 3 commits into
mainfrom
codex/verify-coalescer-cancellation
Sep 5, 2026
Merged

fix(actions): verify coalescer cancellation completion#1887
seonghobae merged 3 commits into
mainfrom
codex/verify-coalescer-cancellation

Conversation

@seonghobae

@seonghobae seonghobae commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • poll the exact Actions run after an accepted current-head coalescer cancellation
  • require terminal completed/cancelled evidence instead of treating HTTP 202 as completion
  • fail closed after six bounded one-second polls
  • prove a failed terminal-state check cannot append a cancelled ID or emit a success report
  • preserve the existing ordinary /cancel endpoint and per-request timeout

Verification

  • uv run pytest tests/test_current_head_run_coalescer.py tests/test_current_head_run_coalescer_review_regressions.py -q — 50 passed
  • git diff --check
  • exact head: d764298469609ec498de91380d256fc65e449252

This implements the cancellation-completion rule documented in #1885 without mixing runtime code into the documentation PR.

@seonghobae
seonghobae enabled auto-merge (squash) September 5, 2026 03:23
@coderabbitai

coderabbitai Bot commented Sep 5, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 58 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 098b6fa8-545e-4a6b-b986-ec8d615bc290

📥 Commits

Reviewing files that changed from the base of the PR and between 0eb41a3 and 90fe695.

📒 Files selected for processing (3)
  • scripts/ci/current_head_run_coalescer.py
  • tests/test_current_head_run_coalescer.py
  • tests/test_current_head_run_coalescer_review_regressions.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 8a15cde into main Sep 5, 2026
3 of 16 checks passed
@seonghobae
seonghobae deleted the codex/verify-coalescer-cancellation branch September 5, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant