Repository navigation
docs(readme): install from the GitHub ZIP; the screen and privacy text name usernames and every comment status - #60
Merged
Merged
Conversation
…een and privacy text name usernames and every comment status readme.txt told site owners to install from Plugins > Add New and that a WordPress.org install updates like any other. The plugin is not in the directory yet: it ships as the GitHub release ZIP and updates are manual, as README.md and RELEASING.md already say. The comment checkbox and the suggested privacy-policy text now say what readme.txt has said since 0.7.0: an export carries authors' WordPress usernames as well as display names, and selected comments of every status (approved, pending, spam and trash), each with its status. Refs #55
…ease ZIP; updates arrive through WordPress once listed readme.txt is the WordPress.org listing source, so a sentence saying the plugin is not in the directory yet turns false the day the review approves. The install step keeps the Plugins > Add New route, conditional on the listing, next to the release ZIP; the update text says WordPress updates it once listed and a ZIP install is updated by uploading the newer ZIP. Refs #55
Member
Author
|
ONAY (t8) @ ccb2ce8 — lean review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55.
Label: GENERIC (docs describe the shipped behaviour; not tied to one site).
Fixed here (true on origin/main 1ad73de, 0.7.0)
readme.txtInstallation: step 1 said "Install Contentrain Bridge from Plugins > Add New", and the update paragraph said "Installed from WordPress.org, the plugin updates like any other". The plugin is not in the directory yet (the submission is in review). Becausereadme.txtis the WordPress.org listing source, the wording is conditional rather than "not listed yet": step 1 keeps Plugins > Add New "once the plugin is listed in the WordPress.org directory", next to the GitHub release ZIP, and the update paragraph says updates arrive through WordPress once listed, while a ZIP install is updated by uploading the newer ZIP (ccb2ce8, review follow-up).includes/class-contentrain-bridge-admin.php:118) now says comments of every status are included. The code exports them all:class-contentrain-bridge-jobs.php:721-735, nocomment_approvedfilter, andapprovedis in each row.wp_add_privacy_policy_content, admin.php:423) now names WordPress usernames (exporter.php:45,100,models.php:335) and comments of every status.Already fixed before this PR
readme.txt:75,83, changelog 0.7.0 third bullet).RELEASING.md:38"Last full clean run (0.7.0): 394 acceptance checks ...", updated in chore(release): 0.7.0 #59.package.json:25-28). npm has since published types 1.62.0, verify 0.3.0, wp-import 0.13.1 and contentrain 0.17.1. That bump is a separate follow-up and is not in this PR. The reader gate run against types 1.62.0 (CONTENTRAIN_TYPES=<packed 1.62.0>/dist/index.mjs npm run test:reader) passes: "Every escape-bearing value survives."Checks (local, clean stack:
down -v, thenKEEP=1)npm run test:wordpress: 394 checks passednpm test: 13/13npm run test:plugin: Plugin Check 0 errors, 4 warnings (the four known WPML hook names)php -lon all 59 PHP files: no errorsNo version bump or changelog entry. The text ships with the next release.