Skip to content

docs(readme): install from the GitHub ZIP; the screen and privacy text name usernames and every comment status - #60

Merged
ABB65 merged 2 commits into
mainfrom
docs/drift-55
Oct 10, 2026
Merged

ABB65 merged 2 commits into
mainfrom
docs/drift-55

Conversation

@ABB65

@ABB65 ABB65 commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

Closes #55.

Label: GENERIC (docs describe the shipped behaviour; not tied to one site).

Fixed here (true on origin/main 1ad73de, 0.7.0)

  • readme.txt Installation: step 1 said "Install Contentrain Bridge from Plugins > Add New", and the update paragraph said "Installed from WordPress.org, the plugin updates like any other". The plugin is not in the directory yet (the submission is in review). Because readme.txt is the WordPress.org listing source, the wording is conditional rather than "not listed yet": step 1 keeps Plugins > Add New "once the plugin is listed in the WordPress.org directory", next to the GitHub release ZIP, and the update paragraph says updates arrive through WordPress once listed, while a ZIP install is updated by uploading the newer ZIP (ccb2ce8, review follow-up).
  • The comment checkbox (includes/class-contentrain-bridge-admin.php:118) now says comments of every status are included. The code exports them all: class-contentrain-bridge-jobs.php:721-735, no comment_approved filter, and approved is in each row.
  • The suggested privacy-policy text (wp_add_privacy_policy_content, admin.php:423) now names WordPress usernames (exporter.php:45,100, models.php:335) and comments of every status.

Already fixed before this PR

  • readme.txt privacy section and comment FAQ: 0.7.0 (chore(release): 0.7.0 #59) already names usernames and every comment status (readme.txt:75,83, changelog 0.7.0 third bullet).
  • Release evidence: RELEASING.md:38 "Last full clean run (0.7.0): 394 acceptance checks ...", updated in chore(release): 0.7.0 #59.
  • Toolchain pins: chore(deps): dev tooling follows the published Contentrain packages #50 moved them from types 1.14.0 / verify 0.2.0 / wp-import 0.5.7 / contentrain 0.13.1 to 1.59.0 / 0.2.0 / 0.11.27 / 0.15.39 (package.json:25-28). npm has since published types 1.62.0, verify 0.3.0, wp-import 0.13.1 and contentrain 0.17.1. That bump is a separate follow-up and is not in this PR. The reader gate run against types 1.62.0 (CONTENTRAIN_TYPES=<packed 1.62.0>/dist/index.mjs npm run test:reader) passes: "Every escape-bearing value survives."

Checks (local, clean stack: down -v, then KEEP=1)

  • npm run test:wordpress: 394 checks passed
  • npm test: 13/13
  • npm run test:plugin: Plugin Check 0 errors, 4 warnings (the four known WPML hook names)
  • php -l on all 59 PHP files: no errors

No version bump or changelog entry. The text ships with the next release.

ABB65 added 2 commits October 9, 2026 21:24
…een and privacy text name usernames and every comment status

readme.txt told site owners to install from Plugins > Add New and that a
WordPress.org install updates like any other. The plugin is not in the
directory yet: it ships as the GitHub release ZIP and updates are manual,
as README.md and RELEASING.md already say.

The comment checkbox and the suggested privacy-policy text now say what
readme.txt has said since 0.7.0: an export carries authors' WordPress
usernames as well as display names, and selected comments of every status
(approved, pending, spam and trash), each with its status.

Refs #55
…ease ZIP; updates arrive through WordPress once listed

readme.txt is the WordPress.org listing source, so a sentence saying the
plugin is not in the directory yet turns false the day the review approves.
The install step keeps the Plugins > Add New route, conditional on the
listing, next to the release ZIP; the update text says WordPress updates it
once listed and a ZIP install is updated by uploading the newer ZIP.

Refs #55
@ABB65

ABB65 commented Oct 10, 2026

Copy link
Copy Markdown
Member Author

ONAY (t8) @ ccb2ce8 — lean review.

  • Each copy claim traced to code on origin/main: every comment status → class-contentrain-bridge-jobs.php comments() selects every row from {$wpdb->comments} with no comment_approved filter and writes approved on each row. Usernames → exporter.php:45,100 user_login. Email/IP/meta not exported → that row has no comment_author_email or comment_author_IP, and meta is empty.
  • readme Installation: conditional wording ("once listed") that matches the fact the WordPress.org submission is still in review.
  • CI green at this head (acceptance, small, small (10), metadata). merge-tree vs origin/main: clean.

@ABB65
ABB65 merged commit c5ad347 into main Oct 10, 2026
8 checks passed
@ABB65
ABB65 deleted the docs/drift-55 branch October 10, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs drift: readme.txt install/update and privacy text, release evidence, toolchain pins

1 participant