Repository navigation
fix(email): no default Reply-To; emails invite a reply only when NUXT_EMAIL_REPLY_TO is set - #465
Merged
Merged
Conversation
…_EMAIL_REPLY_TO is set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GENERIC, promise edge. #463 defaulted
emailReplyToto support@contentrain.io, so on a self-hosted Studio a user's reply to their own instance's email went to Contentrain.nuxt.config.ts:emailReplyTodefaults to''. Unset → the Resend provider sends no Reply-To header (it already skipped an empty value).email-templatesmodel: newreplytext field. The five "reply to this email" sentences moved out ofnotesinto it (payment-failed, subscription-activated, subscription-cancel-scheduled, subscription-canceled, trial-ending). payment-failed keeps "check with your card issuer" in notes; only the reply half moved.emailTemplate()appendsreplyafter the notes only whenNUXT_EMAIL_REPLY_TOis set, so header and sentence are both present or both absent. Unset: omitted, not replaced.replysays "reply to this email". Newresend-email.test.ts: noreplyTofor undefined / '' / whitespace, trimmed header when set..env.example,docs/DEPLOYMENT.md: unset = no Reply-To. Studio docs: Contentrain/docs#17.Deploy note: Studio's own Railway env needs
NUXT_EMAIL_REPLY_TOset to keep replies working there.Checks (local): typecheck 0, lint 0 errors, unit 2340 passed / 2 skipped. test:nuxt fails locally on unchanged main as well (vite cannot resolve nuxt-vitest-app-entry in this worktree), so the nuxt project is left to CI; no nuxt test touches email.