Skip to content

Track public REST route for FindingSearchService.GetSearchTerms #130

Description

@leet-c1

FindingSearchService.GetSearchTerms has a public VIEWER RPC and returns cascaded facet values plus optional match counts, but its proto has no apigw.v1.method.operations annotation. The generated finding OpenAPI contracts expose Search but not this operation, so c1i cannot add a first-class command against the public API.

Evidence: protos/c1api/c1/api/finding/v1/finding.proto defines GetSearchTerms immediately after public Search; Search is annotated POST /api/v1/findings/search, while GetSearchTerms has no REST route. The other absent findings RPCs explicitly state that they are internal-only and should remain excluded: BulkGetFindingSummaries, BulkGetAppResourceFindingSummaries, SearchAppNHIFindings, GetShadowMcpStats, and NotifyShadowMCPUsers.

Follow-up: define and release a public REST route for GetSearchTerms, regenerate OpenAPI/gateway artifacts, then add the corresponding c1i command and live validation.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions