Upgrade CMK standard ceremony and skill wording quality - #25
Merged
Merged
Conversation
Stop drafting docs/requirements from thin or solution-shaped input without a confirmed close package, and require SHALL CONTINUE TO guards on patch Iterate so existing behavior stays explicit in the AC contract.
Give delivery a single home for trivial/patch/feature sizing, the implement docs bar, and one-execution-engine so phases share the same readiness language.
Require the stated scope band's docs bar before implement, routing thin feature work through cmk:requirements instead of skipping to code under pressure.
Make intake state sizing and requirements readiness on the issue and context brief, and capture reproduction before planning fixes on defect issues.
Make completion claims require fresh full verification evidence, and have review cite PREFIX-N.M when walking acceptance criteria.
Block planning and feature-level design when requirements are missing or unconfirmed, and map plan tasks to requirement IDs when they exist.
Give situations a single cmk:* entry table, wire the CLAUDE.md template to it, and ignore local .skills/ scratch used for skill research notes.
Make refs over ~100 lines scannable per the author-skills hierarchy rule.
Align CMK skill frontmatter with the author-skills house form and trim a few outcome nouns (requirements, simplify, repo-setup).
Attribute scope-band to delivery-workflow and compress the superpowers adaptation section so skill-lint stays green.
Trim the body under 150 lines and disambiguate the description from durable cmk:design docs.
Keep the skill body as entry points and pointers; harden split/length contracts that used to read as soft preferences.
Leave mode stubs in SKILL.md and drop the Output section that only restated Create/Iterate/Promote.
Move lens definitions to references for the line budget, add Red Flags and LGTM rationalizations from a grok-4.5 RED baseline, and record TESTS.md.
Add Red Flags plus rationalization rows from a grok-4.5 RED failure, and record GREEN evidence in TESTS.md.
Extend the stale→gRPC table, add Red Flags/rationalizations from a grok-4.5 RED failure, and record TESTS.md.
Document the description house form, codebase-docs/rule reference shape, and the pack-wide remediation outcome.
This was referenced Aug 30, 2026
harrymove-ctrl
added a commit
that referenced
this pull request
Aug 30, 2026
Resolves the overlap with #25, which landed first: - cicd/SKILL.md — keep main's "Use when…" description house form, carry this branch's "add security scanning" / "scan for vulnerabilities" triggers, and take 0.4.0 (a new guidance facet) over main's 0.3.4 wording bump. - delivery-review/SKILL.md — #25 moved the seven lenses out to references/lenses.md, so this branch's inline lens-6 edit had no target left. Re-applied it there instead: the security lens still has to name the scans that backed it and the classes that did not run. Taking either side of that conflict verbatim would have dropped the change silently, with CI green either way. - conventions.md — main's roster, with cmk:cicd moved out of the 0.2.1 clause into the 0.4.x band to match the version this branch sets. - docs/ai/skills/delivery-review.md — record references/lenses.md and the new Red Flags / Rationalizations sections, which #25's lens extraction left out of the companion doc. Verified after resolution: security-scanning.md, the ci-structure security section, the empty-scan-reads-as-clean trap, the three Verify items and the lens-6 scan disclosure are all present; #25's lens extraction and scope-band reference are intact; skill-lint passes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopens #22, which was merged prematurely and has now been reverted from
main.GitHub does not allow reopening a merged PR, so this is a fresh PR carrying the same work. All 17 commits are @jayden-dang's originals, cherry-picked unchanged the diff against
mainis byte-identical to #22 (68 files, +1115/-351).What happened
main(
ae4ae31,567ffba).mainis back to its pre-Upgrade CMK standard ceremony and skill wording quality #22 state forskills/,docs/ai/skills/andscripts/; PR fix: GitHub repo-meta rate limit + dead ParticleScroll WebGL loop #13'sapp/changes were untouched.originally was.
Review notes carried over
A review of #22 turned up four things worth addressing before this lands. They
are not applied here — this branch is @jayden-dang's work verbatim:
skills/delivery-pipeline/SKILL.md— mandatory read feat: worktree-per-task wave execution #1 was narrowed fromcmk:delivery-workflowto itsreferences/scope-band.mdwhile stilllabelled "tracking contract". No item then requires the delivery-workflow
body, so an agent never loads the
execution-ready/ship-readydefinitions that phases 4 and 5 gate on.
docs/ai/skills/conventions.md— the version roster listscmk:agent-instructionsin two mutually exclusive bands in one sentence,and "
0.1.xon the rest — the other delivery-family skills" is false forintake (0.2.2), review (0.2.4), ship (0.3.3) and spec-plan (0.3.3).
scripts/skill-lint.sh—SIZE_BUDGET_ALLOWLIST=(codebase-docs)is nowsubjectless: this branch takes codebase-docs from 160+ lines to 32, so the
exemption lets it silently regrow past the 150-line budget. Note that
emptying the array needs
${ARR[@]+"${ARR[@]}"}orset -ubreaks it onbash 3.2.
skills/sui-sdk/SKILL.md—getObjectappears on both the stale and thecurrent side of a table whose contract is "use the right column".
Ordering
This conflicts with #23 on four files, most importantly
skills/delivery-review/SKILL.md: #23 edits lens 6 in place, this branch movesthe lens block out to
references/lenses.md. Whichever lands second mustre-target that edit rather than taking either side of the conflict, or #23's
change disappears silently with CI still green.
Suggested order: this first, then rebase #23.