Wave-protocol hardening, profile-invariance principle, and skill dedup - #2
Merged
Merged
Conversation
A resuming controller must continue an unfinished wave from its recorded manifest instead of pinning a new base; cache seeding must target a nonexistent destination; dirty-worktree removal escalates instead of forcing; peer-pulled commits stay out of the pulling task's review-package commit list; and a stale peer pick (source task failed or changed) is dropped or held, never integrated. Handoffs reconstruct join status from the ledger's join and escalation records rather than expecting it in the manifest.
Product, protocol, and core logic are profile-invariant; environment differences live only at named composition and materialization surfaces. Engineering principles state what that means per phase (spec, implement, review, evidence), and design guidance gains a profile-neutrality section. A repo's own infra-profile standard refines the rule.
Give each cross-file contract one owning file and reduce other mentions to a pointer: delegation-prompt shape (context-efficiency), ADR supersession (adr-conventions), learn entry format (learn-template), design levels (design-conventions), spec-plan freshness (context- efficiency capsule rules), AC dispositions (acceptance-criteria). Trim in-file repetition in codebase-docs and discover-efforts without dropping any rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports three improvements matured downstream in a consuming repo back to the shared skills, re-expressed generically per CONTRIBUTING.
1. Wave-protocol gap fixes (
fix:)Review of the worktree-per-task wave protocol in production use found five gaps, all in
delivery-pipeline/references/worktree-wave-execution.mdplus one indelivery-handoff:cp -Rinto an existing dir nests instead of merging).2. One code path across infra profiles (
feat:)New principle in
engineering-principles.mdand a matching Profile neutrality section indesign/references/design-guidance.md: product/protocol/core logic is identical across the local stack and every deployed environment; environment differences live only at named composition/materialization surfaces. Stated per phase — spec placement, implementation preference (extend the local materialization rather than branch the shared path), review lens, and evidence semantics (a shared-logic defect first seen deployed is a parity failure to root-cause). A repo's own infra-profile standard refines the rule.3. Dedup onto single owners (
docs:)Applies the single-owner rule — every cross-file contract has exactly one owning file; other mentions are ≤1 line plus a pointer — to duplication the reference split had not yet caught: delegation-prompt shape (→ context-efficiency § Delegation and returns), ADR supersession mechanics (→ adr-conventions § Lifecycle), learn entry format (→ learn-template.md), design levels (→ design-conventions § Design Levels), spec-plan freshness paraphrase (→ context-efficiency capsule rules), spec-plan/workflow AC restatements (→ acceptance-criteria.md), plus in-file trims in codebase-docs (duplicate example tree, split-heuristic restatements) and discover-efforts. No rule loses its only home; each cut's pointer target was verified to own the content before cutting.
Versions bumped per skill (minor for the two behavior/guidance additions, patch elsewhere).
bash scripts/skill-lint.shpasses.