Skip to content

Remove obsolete SteinerTreeInGraphs model - #1172

Merged
GiggleLiu merged 1 commit into
mainfrom
codex/remove-steiner-tree-in-graphs
Sep 20, 2026
Merged

GiggleLiu merged 1 commit into
mainfrom
codex/remove-steiner-tree-in-graphs

Conversation

@isPANN

@isPANN isPANN commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Remove SteinerTreeInGraphs (i64 and One), its ILP reduction, registrations, exports, examples, and dedicated tests.
  • Remove its model and reduction entries from the paper.
  • Keep SteinerTree and its ILP reduction unchanged. No compatibility alias is added.

The removed model accepts edge selections based on terminal reachability without enforcing a tree. SteinerTree remains the model for connected, acyclic solutions. This removes a concrete public type; core Problem, reduction, and solver interfaces are unchanged.

Validation

  • Workspace tests: 6,556 passed, 2 ignored.
  • Clippy: all targets and features, warnings denied.
  • Paper build passed.

10 files changed; 6 additions and 930 deletions.

@codecov

codecov Bot commented Sep 20, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.22%. Comparing base (b002100) to head (1c63d73).

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1172    +/-   ##
========================================
  Coverage   96.21%   96.22%            
========================================
  Files        1074     1070     -4     
  Lines      134038   133605   -433     
========================================
- Hits       128970   128564   -406     
+ Misses       5068     5041    -27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GiggleLiu
GiggleLiu merged commit 5a35ce7 into main Sep 20, 2026
9 checks passed
@isPANN
isPANN deleted the codex/remove-steiner-tree-in-graphs branch September 21, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants