Conversation
Use exact integer CVP and a bipartite solver for K2 coloring. Validate derived model state and report reference-solver size and interval failures explicitly. Correct signed vertex-cover weights and prize-collecting Steiner gadget costs, with regression tests and updated proofs.
Register value mappings beside their implementations and share constructed results across witness and aggregate recovery. Enforce decision thresholds, correct reduction edge cases, and verify typed errors and multi-step mappings.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1171 +/- ##
==========================================
+ Coverage 96.22% 96.75% +0.52%
==========================================
Files 1070 1069 -1
Lines 133605 138821 +5216
==========================================
+ Hits 128564 134312 +5748
+ Misses 5041 4509 -532 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
isPANN
marked this pull request as ready for review
September 21, 2026 06:23
isPANN
marked this pull request as draft
September 21, 2026 06:39
isPANN
marked this pull request as ready for review
September 21, 2026 07:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix reduction result recovery, model validation, and reference-solver correctness while retaining the existing
Problem,SolutionAggregate, and typed witness/value reduction interfaces.API and behavior changes
extract_value.pred extract bundle.json --result result.jsonwith explicitfeasible,optimal,infeasible, orcompletestatus. Optional witness evaluations must match the model's evaluation. A candidate evaluation does not establish optimality or exhaustive NO.Decision<P>. Direct bounded OpenShopScheduling and LongestCircuit ILP encodings add a bound constraint and use a zero objective; their optimization versions retain their objectives.Min<i64>values and thecoefficientvariant key. Persist QUBO asnum_varsplus sparseentries. Register KColoring KN/K2/K3 variants and provide a direct bipartite solver for K2.Core
Problemand solver return interfaces are not migrated. Model-specific getters/parameters, dynamic extraction signatures, persisted formats, and supported variants do change; this is a critical API review.P → Decision<P>remains a Turing edge (binary search over the decision bound).Scope
Against main at head
31bdb314: 404 files changed, 14,058 additions, 4,712 deletions. No website changes. The obsolete SteinerTreeInGraphs removal is already in main and is not part of this diff.Validation
31bdb314: Test, Clippy, Rustfmt, coverage, RISC-V, Windows x86_64, and macOS ARM64 checks passed; Codecov checks passed.ef634c2b: 6,727 passed, 2 ignored. Workspace Clippy with warnings denied, formatting, and paper build passed.67715f12: all 19 solver-registry tests passed.