Skip to content

Validate structured graph and planning model inputs - #1169

Merged
GiggleLiu merged 4 commits into
mainfrom
fix/structured-model-deserialization
Sep 18, 2026
Merged

GiggleLiu merged 4 commits into
mainfrom
fix/structured-model-deserialization

Conversation

@isPANN

@isPANN isPANN commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Apply existing constructor checks during deserialization for ten graph and planning models.
  • Validate weight counts, labelled arcs, contact maps, AND/OR gate inputs, production vectors, and timetable shapes before use.
  • Rebuild PaintShop derived state from the persisted car sequence.
  • Share checks with create specifications; preserve public constructors, generic bounds, JSON output fields, and solver/reduction APIs.

Verification

  • Integrated locally with all extracted safe-change branches: 6,572 workspace all-feature unit/integration tests passed, 2 ignored.
  • Combined changed-line Rust coverage: 99.64% (3,843 of 3,857 measured lines).
  • Workspace all-target all-feature Clippy with warnings denied, formatting, and whitespace checks pass.
  • Static website build-contract checks: 3 passed. No branches have been merged to main.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.43820% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.99%. Comparing base (7dd5fcd) to head (b594f6b).

Files with missing lines Patch % Lines
src/models/misc/paintshop.rs 91.89% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1169      +/-   ##
==========================================
+ Coverage   95.93%   95.99%   +0.06%     
==========================================
  Files        1074     1074              
  Lines      132106   132330     +224     
==========================================
+ Hits       126730   127025     +295     
+ Misses       5376     5305      -71     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@GiggleLiu GiggleLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review: PaintShop state rebuilt from the car sequence, JSON shapes preserved, rejections trace to existing asserts; make check passes locally on the merged state. Approving.

@GiggleLiu
GiggleLiu merged commit b002100 into main Sep 18, 2026
9 checks passed
@isPANN
isPANN deleted the fix/structured-model-deserialization branch September 18, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants