Validate string and scheduling model inputs - #1166
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1166 +/- ##
==========================================
+ Coverage 96.00% 96.14% +0.13%
==========================================
Files 1074 1074
Lines 132526 133475 +949
==========================================
+ Hits 127233 128328 +1095
+ Misses 5293 5147 -146 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…' into fix/scheduling-model-deserialization
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Contributor
|
Final review notes
|
GiggleLiu
approved these changes
Sep 18, 2026
GiggleLiu
left a comment
Contributor
There was a problem hiding this comment.
Final review: cached length bounds rebuilt on load, JSON shapes preserved, rejections trace to existing asserts; make check passes locally on the merged state after the clippy rewrite. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification