Skip to content

Fix combinatorial reduction boundary cases and witness recovery - #1155

Merged
GiggleLiu merged 5 commits into
mainfrom
fix/threepartition-pairing-recovery
Sep 18, 2026
Merged

GiggleLiu merged 5 commits into
mainfrom
fix/threepartition-pairing-recovery

Conversation

@isPANN

@isPANN isPANN commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Normalize interchangeable equal-size pairing elements in 3D matching to 3-partition witness recovery.
  • Handle empty/uncovered matching instances and propagate target arithmetic construction errors.
  • Preserve SetSplitting set semantics for repeated elements and singleton contradictions.
  • Force negative-weight vertex-cover choices in the AND/OR graph construction and recovery.
  • Update the corresponding bounds, proofs, and regression tests.
  • Preserve the existing extract_solution, aggregate, and solver APIs; based on main.

Verification

  • The complete extracted-change integration tree passes 6,572 workspace all-feature unit/integration tests (2 ignored).
  • Constituent changed-line coverage: 100% for matching and negative-weight recovery, 97.14% for SetSplitting.
  • Paper checks passed for the constituent rule changes; consolidation does not change their implementations.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 99.46524% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.95%. Comparing base (7dd5fcd) to head (efc399d).

Files with missing lines Patch % Lines
src/rules/setsplitting_betweenness.rs 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
+ Coverage   95.93%   95.95%   +0.02%     
==========================================
  Files        1074     1074              
  Lines      132106   132208     +102     
==========================================
+ Hits       126730   126865     +135     
+ Misses       5376     5343      -33     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@isPANN isPANN changed the title Fix 3D matching recovery from interchangeable 3-partition elements Fix 3D matching to 3-partition construction and witness recovery Sep 17, 2026
…-and-or-negative-weights' into fix/threepartition-pairing-recovery
@isPANN isPANN changed the title Fix 3D matching to 3-partition construction and witness recovery Fix combinatorial reduction boundary cases and witness recovery Sep 17, 2026

@GiggleLiu GiggleLiu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final review: read all four fixes and the Garey–Johnson normalisation argument; make check and make paper pass locally on the merged state. Approving as-is.

@GiggleLiu
GiggleLiu merged commit 286a7ac into main Sep 18, 2026
9 checks passed
@isPANN
isPANN deleted the fix/threepartition-pairing-recovery branch September 18, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants