Skip to content

feat(cli): wire execution permission controls - #1531

Open
B-A-M-N wants to merge 10 commits into
CodebuffAI:mainfrom
B-A-M-N:security/1450-cli-integration-review-r2
Open

B-A-M-N wants to merge 10 commits into
CodebuffAI:mainfrom
B-A-M-N:security/1450-cli-integration-review-r2

Conversation

@B-A-M-N

@B-A-M-N B-A-M-N commented Oct 17, 2026 •

Copy link
Copy Markdown

CLI execution permission controls and shell approval queue

Wires the SDK execution-permission controls into the CLI and adds a correlated shell-approval lifecycle. The CLI parses and forwards --no-shell, --ask-shell, --project-only, and --read-only. The approval bridge serializes concurrent requests FIFO and resolves active or queued requests as denied on timeout, abort, or UI shutdown.

PR branch and scope

  • Target base: upstream main
  • Head branch: security/1450-cli-integration-review-r2
  • Head: ce39e6c2cb002927b73616e79fbc6ea69f74823b
  • Depends on #1506 and #1530.
  • Incremental diff from patch head 6611d08c6d6a1017f9a7fa9e12b48d5183883fac: 8 files, +540 / -2. Commits: 2bf7c3abd CLI wiring, 772958459 flag tests, and ce39e6c2c approval timeout/abort handling.
  • Incremental compare.

GitHub does not support stacked pull requests across forks, so this follow-up targets upstream main; its displayed diff includes the prerequisite SDK and apply_patch changes until #1506 and #1530 are merged. The incremental compare above shows this follow-up's scope.

Verification

The complete stacked suite passed 98 tests across 9 files: 52 SDK tests, 35 CLI tests, and 11 common tests. The CLI regression files were run from the repository root because package-local startup references the absent cli/test/setup-scm-loader.ts preload. No typecheck diagnostic was reported in changed files.

Inference for this contribution was provided by FreeInference.org. FreeInference did not review, direct, approve, or otherwise participate in this work; all implementation, testing, and publication decisions are the contributor's own. If you find this useful, consider donating to FreeInference.org — they provide a useful and vital service.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant