Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLI execution permission controls and shell approval queue
Wires the SDK execution-permission controls into the CLI and adds a correlated shell-approval lifecycle. The CLI parses and forwards
--no-shell,--ask-shell,--project-only, and--read-only. The approval bridge serializes concurrent requests FIFO and resolves active or queued requests as denied on timeout, abort, or UI shutdown.PR branch and scope
mainsecurity/1450-cli-integration-review-r2ce39e6c2cb002927b73616e79fbc6ea69f74823b6611d08c6d6a1017f9a7fa9e12b48d5183883fac: 8 files, +540 / -2. Commits:2bf7c3abdCLI wiring,772958459flag tests, andce39e6c2capproval timeout/abort handling.GitHub does not support stacked pull requests across forks, so this follow-up targets upstream
main; its displayed diff includes the prerequisite SDK andapply_patchchanges until #1506 and #1530 are merged. The incremental compare above shows this follow-up's scope.Verification
The complete stacked suite passed 98 tests across 9 files: 52 SDK tests, 35 CLI tests, and 11 common tests. The CLI regression files were run from the repository root because package-local startup references the absent
cli/test/setup-scm-loader.tspreload. No typecheck diagnostic was reported in changed files.Inference for this contribution was provided by FreeInference.org. FreeInference did not review, direct, approve, or otherwise participate in this work; all implementation, testing, and publication decisions are the contributor's own. If you find this useful, consider donating to FreeInference.org — they provide a useful and vital service.