London | 2-ITP-Sept | Hugh Mills| Sprint 1 | Form Controls - #1473
Open
HM-127BTY wants to merge 5 commits into
Open
London | 2-ITP-Sept | Hugh Mills| Sprint 1 | Form Controls#1473HM-127BTY wants to merge 5 commits into
HM-127BTY wants to merge 5 commits into
Conversation
Added name at end. done inputs for Size and corrections to colours.
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
HM-127BTY
added
📅 Sprint 1
Luro91
added
the
Review in progress
Luro91
reviewed
Sep 10, 2026
There was a problem hiding this comment.
The lighthouse Accessibility score is below 100. How can you achieve 100?
| <form> | ||
| <div> | ||
| <label for="name">Name:</label> | ||
| <input type="text" id="name" placeholder="Hugh Mills" pattern=".*\S.*\S.*." required> |
There was a problem hiding this comment.
The validation does not allow special characters like the German ä,ü,ö or Russian ед
Author
There was a problem hiding this comment.
I didn't use any of those, wand I cant see where, can you point it out for me?
| <label for="size">XL:</label> | ||
| <input type="radio" name="size" value="xl"> | ||
| <label for="size">XXL:</label> | ||
| <input type="radio" name="size" value="xxl"> |
There was a problem hiding this comment.
FYI: I would change the form types. Radio buttons are good if there are not to many options to choose from. Space on a web page is precious and for inputs with a lot of options, a dropdown can save a lot of space. (You don't need to change anything. This is just an information on the different input types)
Luro91
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
CYF-1004
Added in code as instructed in the readme.md for Form Control.
added requirements for Name, Email, Colour and Size.
Added input buttons for Submit and Reset
Changed text at end to have my name.