Skip to content

London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | To do List - #1463

Open
mandipsanger wants to merge 2 commits into
CodeYourFuture:mainfrom
mandipsanger:alarmclock
Open

mandipsanger wants to merge 2 commits into
CodeYourFuture:mainfrom
mandipsanger:alarmclock

Conversation

@mandipsanger

@mandipsanger mandipsanger commented Sep 9, 2026

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1097

Changelist

Todo list app

@github-actions

This comment has been minimized.

@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2026
@github-actions

This comment has been minimized.

@mandipsanger mandipsanger changed the title London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | Alarm Clock London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | To do list App Sep 9, 2026
@github-actions

This comment has been minimized.

@mandipsanger mandipsanger changed the title London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | To do list App London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | Alarm Clock Sep 9, 2026
@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2026
@github-actions

This comment has been minimized.

@mandipsanger mandipsanger changed the title London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | Alarm Clock London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | To Sep 9, 2026
@mandipsanger mandipsanger changed the title London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | To London | 26-ITP-Sep | Mandip Sanger | Sprint 3 | To do List Sep 9, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@mandipsanger mandipsanger added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 9, 2026

@LonMcGregor LonMcGregor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be careful about your git usage here - this is the todo list task, but you called the branch "alarmclock". Can you resolve that?

Also, did you open this PR before you had fully implemented the task? Can you have another look at the README?

@LonMcGregor LonMcGregor added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 14, 2026
@mandipsanger

Copy link
Copy Markdown
Author

in order to solve this i have to make another branch from main and make a fresh PR. I don't think there is another way I have asked abdi he said thhis shoudl be ok. If you really want me to I can change this and you can review. other wise there is no way i can just change the branch from here unless you know any?

@LonMcGregor

Copy link
Copy Markdown

OK. @mandipsanger if you want to continue on this branch, that's fine. Just keep in mind the need for an appropriate branch name in future.

Could you check and make sure the todo list is complete, then I can review it.

@mandipsanger

Copy link
Copy Markdown
Author

Thank you. ok i will check it it think this. So far it looks ok i will double check the requirements. please check the rest of my things which are complete as I am suppose to finish this before 20 and get badge in order to apply for checkpoint.

@mandipsanger mandipsanger added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants