Skip to content

fix(a11y): restore the main landmark (A5) #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianGenisio merged 3 commits into from
Aug 6, 2026
+9 −9
Merged

fix(a11y): restore the main landmark (A5) #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ea20d56
test: keep a11y-audits tools out of the vitest suite
Aug 6, 2026
3e12961
fix(a11y): restore the main landmark on chat history
Aug 6, 2026
a4e7f01
test: preserve vitest default excludes alongside a11y-audits
Aug 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions a11y-audits/tools/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,40 +3,32 @@
"generated": "2026-08-06",
"scans": {
"dark/empty-state": {
"aria-allowed-role": 1,
"color-contrast": 3,
"landmark-one-main": 1,
"nested-interactive": 2,
"region": 1
},
"dark/settings-modal": {
"aria-allowed-role": 1,
"color-contrast": 4,
"nested-interactive": 3,
"region": 1
},
"dark/settings-modal-dropdown-open": {
"aria-allowed-role": 1,
"aria-input-field-name": 1,
"color-contrast": 4,
"nested-interactive": 3,
"region": 6
},
"light/empty-state": {
"aria-allowed-role": 1,
"color-contrast": 3,
"landmark-one-main": 1,
"nested-interactive": 2,
"region": 1
},
"light/settings-modal": {
"aria-allowed-role": 1,
"color-contrast": 3,
"nested-interactive": 3,
"region": 1
},
"light/settings-modal-dropdown-open": {
"aria-allowed-role": 1,
"aria-input-field-name": 1,
"color-contrast": 3,
"nested-interactive": 3,
Expand Down
2 changes: 1 addition & 1 deletion public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ <h2 class="sidebar__history-heading" id="historyHeading" style="display:none">Hi
<div class="chat-main">

<!-- Chat history -->
<main class="chat-history" id="chatHistory" role="log" aria-live="polite">
<main class="chat-history" id="chatHistory">
<div class="empty-state" id="emptyState">
<span class="cosmo-avatar large" aria-hidden="true"></span>
<h1 class="heading-small empty-state__heading">What's on your mind?</h1>
Expand Down
8 changes: 8 additions & 0 deletions vitest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
import { defineConfig, configDefaults } from 'vitest/config';

export default defineConfig({
test: {
// a11y-audits/tools has its own package and uses node:test, not vitest.
exclude: [...configDefaults.exclude, '**/a11y-audits/**'],
},
});