Repository navigation
Conversation
fix: restore AWS S3 region for avatar upload (lost in revert of #70)
chore: migrate CFA Tinybird workspace from Classic to Forward
…rkflow ci: add monthly upstream sync workflow
Upstream hardcodes dub.co sender addresses which Resend rejects for non-dub.co deployments. Read from EMAIL_FROM_PRIMARY, EMAIL_FROM_NOTIFICATIONS, EMAIL_FROM_MARKETING, and EMAIL_REPLY_TO env vars with dub.co values as fallbacks.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
Isn't this PR doing what #95 is doing? |
Author
|
Hello @nkasozi were you doing this same fix? let me know so we can settle on which one to close. |
|
@VinneyJ , closed mine. I see this PR has changes in github workflows mixed in...can you double check as to why those files are being mixed into this PR |
Author
|
Superseded by #98 — same fix on a clean branch with no unrelated files mixed in. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
system@dub.coas the sender, which Resend rejects for non-dub.co deploymentsfromaddresses (primary,notifications,marketing) and thereplyTofallback configurable via env vars, with the original dub.co values as fallbacksEnv vars to set in Vercel
EMAIL_FROM_PRIMARYCode for Africa <support@codeforafrica.org>EMAIL_FROM_NOTIFICATIONSCode for Africa <support@codeforafrica.org>EMAIL_FROM_MARKETINGCode for Africa <support@codeforafrica.org>EMAIL_REPLY_TOsupport@codeforafrica.orgValues must use a domain verified in your Resend account.
Files changed
packages/email/src/resend/constants.ts- from addresses read from env varspackages/email/src/send-via-resend.ts- replyTo fallback reads from env varCloses CodeForAfrica/infrastructure-as-code#133