Repository navigation
ci: fix invalid shell expressions and preserve both Windows checks - #2
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and resulting behavior
The current workflow is rejected before any jobs are created: run 40145591109 reports
Unrecognized named-value: 'matrix'for both step-levelshellexpressions.matrixis unavailable in that workflow key.Replace the shell matrix with explicit Windows PowerShell 5.1 and PowerShell Core jobs using literal
powershellandpwshshells. Both jobs retain the existing parse check and offline tests. Push checks now run only onmain; pull requests retain their checks without duplicate branch-push runs. Per-PR/ref concurrency cancels stale updates. The macOS bootstrap job, same-repository PR guard, read-only permissions, and checkout pin are preserved.Evidence and validation
mainpush and pull request checks remain enabled, feature-branch push checks are excluded, and concurrency isolates PR numbers and branch refs.bash -n scripts/repo-init.shpasses.python3 tests/check-repository.pypasses.tests/Test-Offline.ps1steps and that the bootstrap runner labels and fork guard remain intact.dd2e5e5: Windows PowerShell 5.1 and PowerShell Core jobs both passed the parser and 18 offline assertions each. Exactly one run was created for this update, triggered bypull_request; no duplicate push run was created.