Skip to content

ci: fix invalid shell expressions and preserve both Windows checks - #2

Merged
fgirolami29 merged 2 commits into
mainfrom
ci/explicit-windows-shells
Oct 25, 2026
Merged

fgirolami29 merged 2 commits into
mainfrom
ci/explicit-windows-shells

Conversation

@fgirolami29

@fgirolami29 fgirolami29 commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor

Problem and resulting behavior

The current workflow is rejected before any jobs are created: run 40145591109 reports Unrecognized named-value: 'matrix' for both step-level shell expressions. matrix is unavailable in that workflow key.

Replace the shell matrix with explicit Windows PowerShell 5.1 and PowerShell Core jobs using literal powershell and pwsh shells. Both jobs retain the existing parse check and offline tests. Push checks now run only on main; pull requests retain their checks without duplicate branch-push runs. Per-PR/ref concurrency cancels stale updates. The macOS bootstrap job, same-repository PR guard, read-only permissions, and checkout pin are preserved.

Evidence and validation

  • Reproduced both original expression errors with actionlint 1.7.12; the updated workflow passes actionlint.
  • Validated event selection: main push and pull request checks remain enabled, feature-branch push checks are excluded, and concurrency isolates PR numbers and branch refs.
  • bash -n scripts/repo-init.sh passes.
  • python3 tests/check-repository.py passes.
  • Checked that both Windows jobs retain the parser and tests/Test-Offline.ps1 steps and that the bootstrap runner labels and fork guard remain intact.
  • Latest PR run 40165092255, head dd2e5e5: Windows PowerShell 5.1 and PowerShell Core jobs both passed the parser and 18 offline assertions each. Exactly one run was created for this update, triggered by pull_request; no duplicate push run was created.
  • The self-hosted macOS bootstrap job is still queued. Its two commands pass locally; the workflow cannot be called fully green until that runner executes the job.
  • Hardware evidence: no compatibility expansion or firmware operations.
  • Restoration and remote-access considerations: no change.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T05:17:38.083968Z 60766d2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fgirolami29
fgirolami29 merged commit fb53b99 into main Oct 25, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant