Skip to content

Assignment 1 miscellaneous (significant!) problems #151

Description

@jrmcgarvey
  1. The assignment asks the student to use callbacks, then a Promise, then async/await. What is meant by the second part, I think is a Promise that is resolved a .then(). It isn't clear. Also, the sample solution for "callback hell" is perhaps not the best, because the operations don't have to be serialized. File open/read/close of one file would be a better example.

  2. The assignment asks the student to use a read stream. Streams are not explained in the lesson however. We could point the student to the documentation and make it clear that this part is a bonus.

  3. The sample answer has a questionable practice, that being writing to the stream without checking the return code. If the return code is false, it is necessary to wait for the stream to drain. Of course it doesn't fail in this case, but we want to teach the best practice.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions