Skip to content

Allow closing in-game dialogs using Escape - #100

Merged
Belonit merged 4 commits into
mainfrom
in-game-dialog-escape
Oct 20, 2026
Merged

Belonit merged 4 commits into
mainfrom
in-game-dialog-escape

Conversation

@Belonit

@Belonit Belonit commented Oct 19, 2026

Copy link
Copy Markdown
Member

Press Escape to go back from in-game menus and dialogs, including diplomacy, briefing, game controls, audio, and save/load/delete dialogs.
From the main pause menu, Escape resumes the game.
In the Abort Mission dialog, it returns to the pause menu.

Escape also works when the save name field has keyboard focus.

Dialogs outside a match retain their existing behavior.

Closes #95

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@MahBoiDeveloper MahBoiDeveloper left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Broken in campaign while input is locked. If I press ESC and after that press ESC again -- battle shows and instantly backs to the menu. Also if I Alt+Tab to other window and back to the game -- ESC doesn't work.

@MahBoiDeveloper

Copy link
Copy Markdown
Member

@Belonit Should I retest it?

@Belonit

Belonit commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

@Belonit Should I retest it?

Please repeat the test with build ddb4594.
Build 561a2d9 had an issue that prevented skipping videos.

As a bonus, Tab can now open the briefing/diplomacy menu while gameplay input is locked.

@MahBoiDeveloper

Copy link
Copy Markdown
Member

This build allow me to see system cursor while load. Is it intended?

@MahBoiDeveloper

Copy link
Copy Markdown
Member

This build allow me to see system cursor while load. Is it intended?

Except this strange rare bug, that could be correlated with cnc-ddraw as my main renderer, all works fine.

@Belonit

Belonit commented Oct 20, 2026

Copy link
Copy Markdown
Member Author

We discussed the cursor issue on Discord and concluded that it is unrelated to this PR

@Belonit
Belonit merged commit de64f07 into main Oct 20, 2026
3 checks passed
@Belonit
Belonit deleted the in-game-dialog-escape branch October 20, 2026 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make in-game menu be able close by ESC key

2 participants