Skip to content

[CP-49297] Support description on group and allocation dimensions - #22

Open
marvilion wants to merge 4 commits into
Cloudzero:mainfrom
marvilion:CP-49297-dimension-description
Open

marvilion wants to merge 4 commits into
Cloudzero:mainfrom
marvilion:CP-49297-dimension-description

Conversation

@marvilion

Copy link
Copy Markdown

Description of the change

Adds description to GroupDimension and AllocationDimension and writes it to YAML as Description: right after Name:; today it's silently dropped. Bumps the version to 0.3.0, which needs a GitHub Release to publish to PyPI.

Type of change

  • Bug fix
  • New feature

Checklists

Development

  • CHANGELOG.md has been updated if appropriate
  • version in costformation/__init__.py has been updated if appropriate

Code review

  • This pull request has a title with a short useful summary of the change.

@marvilion

Copy link
Copy Markdown
Author

@greptileai review and give score

@greptile-apps

greptile-apps Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Adds optional description text to GroupDimension and AllocationDimension.

  • Group and allocation dimensions can carry hover descriptions.

Reviews (3) · Last reviewed commit: "Merge branch 'main' into CP-49297-dimens..." · Reviewed by Greptile

@marvilion
marvilion marked this pull request as ready for review October 23, 2026 10:31
@marvilion
marvilion requested a review from a team as a code owner October 23, 2026 10:31

@silvexis silvexis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Optional description on GroupDimension and AllocationDimension is emitted as YAML Description: right after Name:, with unit tests pinning both the value and the key order, docs and CHANGELOG updated, and the 0.3.0 bump matching an additive API. CI is green including validate-changelog and version-check. Approving. After merge, cut a GitHub Release so 0.3.0 publishes to PyPI — merge alone won’t.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants