Repository navigation
Conversation
Author
|
@greptileai review and give score |
[Low impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds optional
Reviews (3) · Last reviewed commit: "Merge branch 'main' into CP-49297-dimens..." · Reviewed by Greptile |
marvilion
marked this pull request as ready for review
October 23, 2026 10:31
silvexis
approved these changes
Oct 23, 2026
silvexis
left a comment
Member
There was a problem hiding this comment.
Looks good. Optional description on GroupDimension and AllocationDimension is emitted as YAML Description: right after Name:, with unit tests pinning both the value and the key order, docs and CHANGELOG updated, and the 0.3.0 bump matching an additive API. CI is green including validate-changelog and version-check. Approving. After merge, cut a GitHub Release so 0.3.0 publishes to PyPI — merge alone won’t.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change
Adds description to GroupDimension and AllocationDimension and writes it to YAML as Description: right after Name:; today it's silently dropped. Bumps the version to 0.3.0, which needs a GitHub Release to publish to PyPI.
Type of change
Checklists
Development
costformation/__init__.pyhas been updated if appropriateCode review