Upd. Composer metadata: description, homepage, keywords, support - #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata only, no code changes.
Why. Packagist takes the package description from
composer.json, not from the GitHub About field. Right now packagist.org/packages/cleantalk/contacts-encoder shows "CleanTalk ContactsEncoder class", so the package is not findable by the head keyword "email obfuscation" either in Packagist search or in Google. The repository itself is already updated.What changed in composer.json
description- product description with the head keywordhomepage- link to the product page cleantalk.org/contact-encoderkeywords- 10 search terms used inside Packagistsupport- issues and source linksEverything else, including the package name and dependencies, is untouched. The package name stays
cleantalk/contacts-encoder: renaming would break Composer installs for existing users.What is needed after the merge
Packagist only refreshes metadata on a new release, so please tag a patch version after merging. The webhook works - 2.1.0 appeared on Packagist automatically.
One more thing, unrelated to this PR but worth a look
ContactsEncoder.phphasconst VERSION = '2.0.19', while the latest tag is 2.1.0. That constant goes into the agent string sent to the cloud (contacts_encoder_lib_2.0.19), so our own statistics report an outdated library version. Worth bumping together with the next tag.Acceptance: packagist.org/packages/cleantalk/contacts-encoder shows the new description, the product page link and the keyword list.