Repository navigation
PNE-9647: state that allowed_names is deprecated - #240
Merged
Merged
Conversation
The ProcessTemplate docstring states that the Citrine Platform ignores a supplied allowed_names list and fills the field on read with the distinct names from the template's ingredient specs. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
wjohnald
changed the title
allowed_names is deprecated
wjohnald
marked this pull request as ready for review
October 29, 2026 15:14
…mic-ingredient-names-wt
GitHub's ubuntu-latest image now ships Python 3.14, and the docs job builds with the runner's default interpreter. Sphinx 5.0.0 imports imghdr, which Python 3.13 removed, so the docs gate failed. Sphinx 8.1.3 is the newest release that still supports Python 3.10. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kroenlein
self-requested a review
November 2, 2026 18:14
kroenlein
approved these changes
Nov 2, 2026
kroenlein
left a comment
kroenlein
left a comment
Collaborator
There was a problem hiding this comment.
Looks good. I bumped the sphinx version as we were shipping w/ a Sphinx version incompatible with Python 3.14.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEMD Python PR
Description
Ticket: https://citrine.atlassian.net/browse/PNE-9647
Deprecate
ProcessTemplate.allowed_namesas part of PNE-9643. Users can choose ingredient names without this field.GEMD Python keeps the field to give users time to migrate code and JSON away from it. This PR documents how the Citrine Platform treats it:
To satisfy a sphinx build with Python 3.14, sphinx version is bumped as well.
Release notes
ProcessTemplate.allowed_namesis deprecated but remains in GEMD Python to give users time to migrate code and JSON away from it.PR Type
Adherence to team decisions