This repository was archived by the owner on Oct 15, 2026. It is now read-only.
Repository navigation
Conversation
|
@dokterbob what is needed to get this merged? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Share links omit the app root path when Chainlit is served under a subpath. For example,
/chatdeployments generate/share/<id>instead of/chat/share/<id>.Fix
Reuse
getRouterBasename()inShareDialogand remove the trailing slash before building the URL.Scope
Package:
@chainlit/app.frontend/src/components/share/ShareDialog.tsxfrontend/tests/ShareDialog.spec.tsxTests
Added 7 cases covering root and nested paths, trailing slashes, displayed links, and clipboard copies for new and existing shares.
pnpm test(55 passed),pnpm lint,pnpm format-check, andpnpm type-checkpassed. Browser E2E tests were not run.Fixes #3072.
Summary by cubic
Fixes share links dropping the app root path when Chainlit runs under a subpath, so
/chatdeployments now produce/chat/share/<id>instead of/share/<id>.Reuses
getRouterBasename()inShareDialogand strips the trailing slash before building the share URL. Adds 7 unit test cases covering root and nested paths, trailing slashes, and clipboard copies for new and existing shares.Written for commit ec6d9cc. Summary will update on new commits.