Skip to content

Docker DiD support - #187

Draft
Saaketh0 wants to merge 1 commit into
mainfrom
CAN-411-DiD-Support
Draft

Saaketh0 wants to merge 1 commit into
mainfrom
CAN-411-DiD-Support

Conversation

@Saaketh0

Copy link
Copy Markdown
Collaborator

If user code contains Docker commands, it used to fail because it thought it was outside of docker but canyonizing the workflow puts everything in docker containers which results in failures.

The vast majority of the code changes was just taking shared code out of EC2/Local _runtime.py and putting them in a shared file too btw.

The actual docker-in-docker support may be a bit brittle too so let me know

@Saaketh0 Saaketh0 self-assigned this Sep 23, 2026
@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Saaketh0 Saaketh0 added Non-Critical Fix Something that fixes something, but is not of utmost importance Core Pertaining to canyonos_core, the core systems in this repo labels Sep 23, 2026
@Saaketh0
Saaketh0 marked this pull request as draft September 23, 2026 19:49
@nickhuo

nickhuo commented Sep 23, 2026

Copy link
Copy Markdown
Collaborator

some related updates need to be aware of: #177 need to changed accordingly

@userAugustos

Copy link
Copy Markdown

Heads up: this branch predates #163, which moved controller/cloud_provider_logic/* to reconciler/providers/* and replaced instance_manager.py with reconciler/provisioner.py. The runtime files this PR refactors no longer exist at these paths on main, so the shared agent_container.py extraction needs to be redone under reconciler/providers/shared_utils/. #196 also adds a docker_container_name(instance) function to each provider's _runtime.py and a stale-status clear before docker run in the Local bootstrap; if the docker run assembly moves into the shared module, those should move with it. Also, buttercup.zip looks like it was committed by accident.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Pertaining to canyonos_core, the core systems in this repo Non-Critical Fix Something that fixes something, but is not of utmost importance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants